Avoid to flush an extra buffer when the string isn't too large in Mes…#293
Merged
xerial merged 3 commits intov07-developfrom Nov 17, 2015
Merged
Avoid to flush an extra buffer when the string isn't too large in Mes…#293xerial merged 3 commits intov07-developfrom
xerial merged 3 commits intov07-developfrom
Conversation
…sagePack#packString
Member
Author
Member
There was a problem hiding this comment.
This involves a look up of the character encoding type table. Use MessagePack.UTF8
Member
|
According to https://blogs.oracle.com/xuemingshen/entry/faster_new_string_bytes_cs, JVM improved the performance of |
Member
Author
|
Thanks for the comments. I'll address them tomorrow. |
Member
Author
|
@xerial Updated! |
xerial
added a commit
that referenced
this pull request
Nov 17, 2015
Avoid to flush an extra buffer when the string isn't too large in Mes…
Member
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sagePack#packString
Fix #292