ValueFactory.MapBuilder is preferred to preserve value order#336
Merged
ValueFactory.MapBuilder is preferred to preserve value order#336
Conversation
ImmutableMapValueImpl preserves order of values. This is preferred behavior because it's preffered if created map objects preserve order of values when an application forwards a received (or deserialized) objects into another application without modifying it. This pull-request applies this preference to MapBuilder. Performance impact should be small because MapBuilder API is a minor API.
frsyuki
changed the title
xerial
added a commit
that referenced
this pull request
Jan 22, 2016
ValueFactory.MapBuilder is preferred to preserve value order
Member
|
I also hit this problem when using msgpack v8 for plazmadb-mpcfile. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImmutableMapValueImpl preserves order of values. This is preferred
behavior because it's preffered if created map objects preserve order of
values when an application forwards a received (or deserialized) objects
into another application without modifying it. This pull-request applies
this preference to MapBuilder.
Performance impact should be small because MapBuilder API is a minor
API.