Conversation
|
Found one performance regression: |
|
The performance regression never occurs in my local machine. It seems a problem of running test code inside a container of Travis. That test should be more lenient (e.g., just show warning) |
|
@komamitsu Could you check this PR? (cc: @xuwei-k) |
| > findbugs # Produce findbugs report in target/findbugs | ||
| > jacoco:cover # Report the code coverage of tests to target/jacoco folder | ||
| > jcheckStyle # Run check style | ||
| > scalafmt # Reformat Scala codes |
There was a problem hiding this comment.
https://github.com/lucidsoftware/neo-sbt-scalafmt/blob/1.14/README.md#usage
scalafmt # format compile sources
test:scalafmt # format test sources
sbt:scalafmt # format .sbt source
The scalafmt command format only compile sources
There was a problem hiding this comment.
| - env: PROJECT=java8 | ||
| jdk: oraclejdk8 | ||
| script: | ||
| - ./sbt test |
There was a problem hiding this comment.
add sbt ";scalafmt::test ;test:scalafmt::test ;sbt:scalafmt::test" ?
https://github.com/lucidsoftware/neo-sbt-scalafmt/blob/1.14/README.md#usage
https://github.com/sbt/sbt/blob/v1.0.4/.travis.yml#L20
To ensure everything is formatted, and fail if it is not (e.g. as a CI step),
>scalafmt::test # check compile sources
>test:scalafmt::test # check test sources
>sbt:scalafmt::test # check .sbt sources
There was a problem hiding this comment.
Ah, Maybe I was wrong. You added addSbtPlugin("com.geirsson" % "sbt-scalafmt" % "1.3.0"), not neo-sbt-scalafmt 🙇
There was a problem hiding this comment.
Right. sbt-scalafmt reformats everything including main, test, *.sbt, etc.
|
Thanks for checking! @komamitsu @xuwei-k |
3 participants
For better Java9 support.
-target 1.7)