Skip to content

Fix strings of integers over 2^63-1 gets encoded as float64 instead of uint64 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aesy wants to merge 3 commits into from
Closed

Fix strings of integers over 2^63-1 gets encoded as float64 instead of uint64 #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47460e2
Change order of which string is tried as number types
aesy Oct 15, 2018
82c120d
Compare biginteger rather than double when testing uint64 serialization
aesy Oct 15, 2018
c54dd9a
Use a value whose string representation is fractional for float64 test
aesy Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,22 +441,6 @@ public void writeNumber(String encodedValue)
// There is a room to improve this API's performance while the implementation is robust.
// If users can use other MessagePackGenerator#writeNumber APIs that accept
// proper numeric types not String, it's better to use the other APIs instead.
try {
long l = Long.parseLong(encodedValue);
addValueToStackTop(l);
return;
}
catch (NumberFormatException e) {
}

try {
double d = Double.parseDouble(encodedValue);
addValueToStackTop(d);
return;
}
catch (NumberFormatException e) {
}

try {
BigInteger bi = new BigInteger(encodedValue);
addValueToStackTop(bi);
Expand Down
6 changes: 3 additions & 3 deletions msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,7 @@ public void serializeStringAsBigDecimal()
objectMapper.registerModule(
new SimpleModule().addSerializer(BigDecimal.class, new BigDecimalSerializerStoringAsString()));

BigDecimal bd = BigDecimal.valueOf(Long.MAX_VALUE).add(BigDecimal.ONE);
BigDecimal bd = BigDecimal.valueOf(Double.MAX_VALUE);
assertThat(
MessagePack.newDefaultUnpacker(objectMapper.writeValueAsBytes(bd)).unpackDouble(),
is(bd.doubleValue()));
Expand All @@ -881,7 +881,7 @@ public void serializeStringAsBigInteger()

BigInteger bi = BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE);
assertThat(
MessagePack.newDefaultUnpacker(objectMapper.writeValueAsBytes(bi)).unpackDouble(),
is(bi.doubleValue()));
MessagePack.newDefaultUnpacker(objectMapper.writeValueAsBytes(bi)).unpackBigInteger(),
is(bi));
}
}