change few features to support scala MessagePack#5
Merged
muga merged 5 commits intomsgpack:masterfrom Oct 17, 2011
Merged
Conversation
added 2 commits
October 13, 2011 03:13
…add new constructor to MessagePack.java
Member
|
Hi Yoshiteru, Thanks a lot for your contribution on MessagePack for Scala! Thanks, Muga Nishizawa |
added 3 commits
October 14, 2011 11:41
…ublic -> protected
Add new method to MessagePack.java @ lookup(Type)
Member
|
Hi Yoshiteru, I checked your codes and merged. Thank you for your contribution!! Muga Nishizawa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implement MessagePack for scala.
But few features are not suit for scala.I changed them.
Please merge them.
Summary
change accessibility : TemplateBuilderChain@reset private -> protected
instantiate TemplateBuilderChain in method: TemplateREgstry@createTemplateBuilderChain
add new constructor : MessagePack@constructor(TemplateRegistry registry)