adding a method writePayload(String src) #667
Closed
nathan-sigsci wants to merge 2 commits intomsgpack:mainfrom
Closed
adding a method writePayload(String src) #667nathan-sigsci wants to merge 2 commits intomsgpack:mainfrom
nathan-sigsci wants to merge 2 commits intomsgpack:mainfrom
Conversation
xerial
reviewed
Sep 24, 2023
|
|
||
| public MessagePacker writePayload(String src) throws IOException | ||
| { | ||
| int len = src.length(); |
Member
There was a problem hiding this comment.
If the input string contains non-ascii characters, src.getBytes() will produce a longer array than src.length(), so using this method can easily create corrupted data.
xerial
reviewed
Sep 24, 2023
| if (buffer == null || buffer.size() - position < len || len > bufferFlushThreshold) { | ||
| flush(); // call flush before write | ||
| // Directly write payload to the output without using the buffer | ||
| out.write(src.getBytes(), 0, len); |
Member
There was a problem hiding this comment.
If calling src.getBytes() is allowed here, you should be able to use addPayload(byte[]) instead.
Member
|
Hi @nathan-sigsci, Thank you for creating a PR, but the intended optimization is already available as .addPayload method. You can use these methods instead. I'll close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new method copies the lower 8-bits of the characters. A separate writePayload(String src) method would be more performant because we're able to directly copy the bytes from the string to the right location in MessageBuffer. Introducing encoding in an attempt to re-use the existing writePayload(byte[] src) creates unnecessary overhead which in turn will affect performance.