asyncio for embedder.py and Update ollama.py for async request to embedder #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edder # Description Use await asyncio.gather(*tasks) for async def _async_embed_chunk with semaphore as in LLMEntityRelationExtractor add async def async_embed_query and self.async_client = ollama.AsyncClient(**kwargs) to use self.async_client = ollama.AsyncClient(**kwargs) > **Note** > > Please provide a description of the work completed in this PR below > > ## Type of Change - [x] New feature - [ ] Bug fix - [ ] Breaking change - [ ] Documentation update - [ ] Project configuration change ## Complexity > **Note** > > Please provide an estimated complexity of this PR of either Low, Medium or High > > Complexity: Low ## How Has This Been Tested? - [ ] Unit tests - [ ] E2E tests - [x] Manual tests # Checklist The following requirements should have been met (depending on the changes in the branch): - [x] Documentation has been updated - [ ] Unit tests have been updated - [ ] E2E tests have been updated - [x] Examples have been updated - [ ] New files have copyright header - [x] CLA (https://neo4j.com/developer/cla/) has been signed - [ ] CHANGELOG.md updated if appropriate
stellasia
reviewed
Dec 1, 2025
Contributor
stellasia
left a comment
stellasia
left a comment
There was a problem hiding this comment.
Nice one!
For this to work with all embedders, we need to add async_embed_query to the Embedder base class. I'd suggest to add a default implementation that calls the non async method, so that we do not have to work on the actual async implementation for all embedders right now, we will be able to add them progressively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use await asyncio.gather(*tasks) for async def _async_embed_chunk with semaphore as in LLMEntityRelationExtractor add async def async_embed_query
and self.async_client = ollama.AsyncClient(**kwargs) to use self.async_client = ollama.AsyncClient(**kwargs)
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):