Document exit logic in task wrapper script#7290
Merged
Merged
Conversation
✅ Deploy Preview for nextflow-docs canceled.
|
pditommaso
approved these changes
Jul 23, 2026
pditommaso
left a comment
pditommaso
left a comment
Member
There was a problem hiding this comment.
LGTM — verified the comments against the actual bash and the rendering path:
BashTemplateEnginestrips all##-prefixed lines, so the rendered wrapper is unchanged. ✓on_exitprecedence, the0-of-last-command note, and theset -e/set -ufallback path all match the code. ✓nxf_unstageconditional (outputs only whennxf_main_ret==0, controls unconditional) is accurate. ✓
Nice-to-have (non-blocking): the nxf_unstage_controls comment says its exit status "becomes the generic last_err fallback in on_exit", but that only holds when no after script is defined — with {{after_script}} present, it runs after nxf_unstage, so $? reflects the after script and a controls failure is lost rather than surfaced as last_err. Could tighten to "…unless an after script runs later."
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
force-pushed
the
5556-docs-bash-unstage-logic
branch
3 times, most recently
from
July 23, 2026 16:24
1d1f929 to
5c1d175
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #5556
Runtime behavior is unchanged since comments are stripped from the rendered wrapper script