Open
Conversation
…ounds. Extra scripts for checking logs. Added player markers and specially marked signed to the map
Owner
|
I will check you pull as I have been thinking of adding overviewer myself. If It's implemented it will be as a separate tag <i.e overviewer> to allow people to choose if there is interested to add the functionality as it will add more memory and cpu. If I add it you will be credited for it |
Author
|
Good idea on the new tag. I'll leave it with you, enjoy! |
Contributor
|
Docker containers are meant to be running only ONE service per container. You should not do that as it will break maintainability, flexibility and make stuff go more complex. Something you should do is to use multiple containers and link them together. Docker Compose is a good thing to try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I have added Overviewer support to your docker image. Happy for you to reject this pull if you want to keep your docker image clean and simple, also happy for you to critique the way I did things and reject it for that (most of it could be done a lot better!).
I originally forked and played with your repo to learn about using docker, and was going to keep my hacked changes to myself. I wrote them quickly just to get things going, but later realised this kind of thing may be appreciated by others.
If you have better ways of doing things or want me to change anything, don't hesitate to ask. Also, don't feel obliged to take any of this on, only if you're interested :)
Thanks! Love your work.
Cheers,
Mark.