Skip to content

added c# porting of lz77#2

Closed
gitPhate wants to merge 1 commit intoolle:masterfrom
gitPhate:master
Closed

added c# porting of lz77#2
gitPhate wants to merge 1 commit intoolle:masterfrom
gitPhate:master

Conversation

@gitPhate
Copy link

@gitPhate gitPhate commented Nov 2, 2015

Hello, I added a C# porting of the LZ77 algorithm, as I ported the java implementation for a project of mine. My implementation works on bytes.

@olle
Copy link
Owner

olle commented Nov 4, 2015

Hi, looks great. I'd love to pull this into the repo.

How about adding a small test, though? Also, any pointers on how to get such tests also running with the Mono-SDK would be super.

Thanks!

@gitPhate
Copy link
Author

gitPhate commented Nov 4, 2015

I have to worry you about the performance, I'm currently working to make it
quicker, and I'll add some tests. We'll stay in touch
Il 04/nov/2015 10:39 PM, "Olle Törnström" notifications@github.com ha
scritto:

Hi, looks great. I'd love to pull this into the repo.

How about adding a small test, though? Also, any pointers on how to get
such tests also running with the Mono-SDK would be super.

Thanks!


Reply to this email directly or view it on GitHub
#2 (comment).

@gitPhate
Copy link
Author

gitPhate commented Nov 5, 2015

Updates: I found the issue, in these days I will make another pull request with the right class. As for the mono tests, I never used it but I think that the test methods are the same as visual studios. I will post them in the new pull request, but consider that I don't have pretty much time (I'm at work and I develop only when I have nothing else to do).
I'll be in touch!

@gitPhate gitPhate closed this Nov 5, 2015
@olle
Copy link
Owner

olle commented Nov 5, 2015

Hi, sounds great. And regarding the tests/Mono - don't worry, it's all good.

I'll pull and merge when you're done. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants