Skip to content

Conversation

@Domratchev
Copy link

No description provided.

@ebrehault
Copy link
Collaborator

Hi @Domratchev, thank you for contributing!
Your PR looks good to me, I have just noticed the build is broken because of the browserslist queries (see https://travis-ci.org/onna/ngx-speech/builds/433619559?utm_source=github_status&utm_medium=notification).

I am not familiar with browserslist syntax, if you think you can fix this build failure, please do, else I guess I am ok to merge it anyway.

@Domratchev
Copy link
Author

@ebrehault I will have a look

Fixed type safety and tslint issues.
Upgraded to @angular 7.x.
@Domratchev
Copy link
Author

With the new changes I don't seem to get any build or build:lib errors locally.
I've removed node_modules and installed everything fresh.

@ebrehault
Copy link
Collaborator

Thanks @Domratchev !
Apparently Travis is still complaining, but that's just because the CLI test command changed a little bit in Angular 7.
I'll fix it.

@ebrehault ebrehault merged commit dd04313 into onna:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants