Sync evaluation schemas with the final 1.0 text - #599
Open
kanywst wants to merge 1 commit into
Open
Conversation
The schemas still encoded the draft-01 model: a Reasons-shaped Decision `context`, `additionalProperties: false` on the request, and `$comment` anchors pointing at authorization-api-1_0-01.html. Signed-off-by: kanywst <niwatakuma@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schemas under
api/schemas/still encode the draft-01 model, and reject the specification's own examples.evaluation-response.schema.jsonconstrains the Decisioncontextto the draft-01 Reasons object, requiring anidmember and forbidding anything else. Section 5.5.1 definescontextas an object with no required members, and Section 5.5.2 places its semantics and format outside the scope of the specification.evaluation-request.schema.jsonsetsadditionalProperties: false, contradicting Section 10.1.1: receivers MUST ignore unknown fields. The$commentanchors point atauthorization-api-1_0-01.html, and two of them use#name-access-evaluation-decision, which no longer resolves in the published document.This relaxes
contextto a plain object, dropsadditionalProperties: falsefrom the request schema, and repoints the anchors.Checked with Draft 2020-12: the Section 7.2 and 7.1.2.1 response examples and the Obligations profile
context.obligationsshape are rejected before and accepted after.Fixes #598.