Skip to content

Conversation

@aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Dec 8, 2025

This PR :

  • Restructures the exception message displayed when the email send trigger fails, to show the root cause of the issue at the top before the trigger message
  • Increases the initial height of alert dialog for a better visibility

Alert dialog after the change :

Screenshot 2025-12-08 at 12 23 02

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8432: Better exception handling for Email Trigger failure (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/692/head:pull/692
$ git checkout pull/692

Update a local copy of the PR:
$ git checkout pull/692
$ git pull https://git.openjdk.org/jmc.git pull/692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 692

View PR using the GUI difftool:
$ git pr show -t 692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/692.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8432: Better exception handling for Email Trigger failure

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1034873: 8474: Eclipse platform upgrade to 2025_09

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Dec 8, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

@openjdk openjdk bot added the ready label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants