Fix Ignored Dict Keys in Agent Portrayal #2918
Open
+2
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
reviewed
Dec 3, 2025
tests/test_components_matplotlib.py
Outdated
Comment on lines
39
to
42
| return { | ||
| "size": 10, | ||
| "color": "tab:blue", | ||
| "marker": "s" if (agent.unique_id % 2) == 0 else "o", |
Member
There was a problem hiding this comment.
This is changing stuff backwards right? Using dicts is deprecated, we now use AgentPortrayalStyle objects.
See #2786 and #2872, and our migration guide.
Contributor
Author
There was a problem hiding this comment.
Okay I will look on to it.
This comment was marked as off-topic.
This comment was marked as off-topic.
EwoutH
reviewed
Dec 4, 2025
tests/test_devs.py
Outdated
Comment on lines
138
to
140
| # The runtime now emits a FutureWarning for this deprecation. | ||
| # Update test to match the current warning type. | ||
| with pytest.warns(FutureWarning, match="simulator.time is deprecated"): |
Member
There was a problem hiding this comment.
Thanks for catching this. This was a bit time pressing however, so I already fixed it in #2922.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
UserWarnings caused by using incorrect keys (s,c,linecolors) in agent portrayal dictionaries within tests and clarified documentation.Bug / Issue #2904
The issue was that tests/test_components_matplotlib.py was using Matplotlib-style keys (
s,c) in the dictionary returned by agent_portrayal, which are not recognized by Mesa'smpl_space_drawingmodule. This led to multipleUserWarning: The following keys from the returned dict were ignoredmessages during testing. Additionally, the documentation in mpl_space_drawing.py needed consistent formatting for valid keys.Implementation
mpl_space_drawing:"s"with"size"."c"with"color"."linecolors"with"edgecolors"."size","color", etc.) for better readability and accuracy.Testing
pytest tests/test_components_matplotlib.py -W alwaysand verified that theUserWarning: The following keys from the returned dict were ignoredmessages are no longer present.Additional Notes
This ensures that the tests follow the recommended way of defining agent portrayals and keeps the test output clean.