-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-102140: fix false negative in csv.Sniffer.has_header #103341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Drakariboo
wants to merge
75
commits into
python:main
Choose a base branch
from
Drakariboo:has_header_false_neg_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−2
Open
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
60d7501
fixing has_header
johnD18 1636e7b
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo 7020dd5
Merge branch 'main' into has_header_false_neg_fix
Drakariboo e2a76d9
adding genericalias
johnD18 02b645d
adding fieldnames
johnD18 747cbc8
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 6db356f
correcting deletions
johnD18 38166fe
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 2fe30c0
correction of comments
johnD18 b78cd78
corrections
johnD18 9ce92ba
adding the deleted line (if isinstance(colType, int): # it's a length)
johnD18 ccf9d2e
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 8ae2789
correcting...
johnD18 90c70b4
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 1c2fef7
Update Lib/csv.py
johnD18 ba6083c
Update Lib/csv.py
johnD18 2b8c27e
Update Lib/csv.py
johnD18 7ba8c83
Update Lib/csv.py
johnD18 92f63f6
Update Lib/csv.py
johnD18 a1d84d6
Update Lib/csv.py
johnD18 ca440f7
Update Lib/csv.py
johnD18 f60bc70
Update Lib/csv.py
johnD18 22d8b55
Update Lib/csv.py
johnD18 2852554
Update Lib/csv.py
johnD18 1a9ed20
restore blank lines
merwok d381110
Apply suggestions from code review
johnD18 3384c99
📜🤖 Added by blurb_it.
blurb-it[bot] e306d93
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 d167d6d
test for issue #102140
johnD18 17d4a7e
adding space
johnD18 95c1dae
patch check correction
johnD18 b978f18
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 d7d2be5
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 d8f180e
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo eb80cbb
rephrase comment line 449
Drakariboo 3c62566
doc in csv.rst improved for has_header function
Drakariboo 9754874
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 e1f3e1b
delete whitespace in csv.rst
Drakariboo 891b657
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo d01e7a4
delete the final whitespaces
Drakariboo a390543
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 57c58ce
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo 42c00e1
merged the 2 loops line 400
Drakariboo 84b6dda
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 6950c1e
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 bffbcf7
Update Lib/test/test_csv.py
johnD18 b3d0bf2
update csv.py
johnD18 b6a557c
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 8561127
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo 04ee833
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 a0a5544
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 0ab2649
updating csv.rst
johnD18 1d63e98
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 5aabf60
whatsnew update
johnD18 61dfb3e
whatsnew update
johnD18 34e52fa
whatsnew update
johnD18 d0f33be
resolve conflict
johnD18 8fe8b7c
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 3e2b806
misc/news update
johnD18 2e8d2f2
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 b77dc4c
Update Misc/NEWS.d/next/Library/2023-05-01-18-53-20.gh-issue-102140._…
johnD18 bb136bb
adding a comment on csv.py & csv.rst update
johnD18 dcf1af4
Merge branch 'main' into has_header_false_neg_fix
Drakariboo 920cc1e
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 1971df6
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 8746e64
Merge branch 'main' into has_header_false_neg_fix
johnD18 a9ea1be
Merge branch 'main' into has_header_false_neg_fix
Drakariboo 6d139a6
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 141cf5d
Merge branch 'main' into has_header_false_neg_fix
Drakariboo 9686653
Update Lib/csv.py
Drakariboo 680c67b
Update Misc/NEWS.d/next/Library/2023-05-01-18-53-20.gh-issue-102140._…
Drakariboo 149938a
Update Lib/csv.py
Drakariboo 4b22c77
Update Lib/csv.py
Drakariboo 2092173
Update Lib/csv.py
Drakariboo 95f2b61
Merge branch 'main' into has_header_false_neg_fix
Drakariboo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
corrections
- Loading branch information
commit b78cd788a85caffd9d96610cf434e34785c2df98
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.