Skip to content

gh-109936: return on EOF in shutil.copyfileobj#109939

Open
rpigott wants to merge 1 commit into
python:mainfrom
rpigott:copyfileobj-eof
Open

gh-109936: return on EOF in shutil.copyfileobj#109939
rpigott wants to merge 1 commit into
python:mainfrom
rpigott:copyfileobj-eof

Conversation

@rpigott
Copy link
Copy Markdown
Contributor

@rpigott rpigott commented Sep 27, 2023

Alters the loop condition to break on short read.

Copy link
Copy Markdown
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted on the issue, a short read doesn't always indicate EOF.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 4, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants