Skip to content

bpo-35954: Clarify string conversion in ConfigParser#11918

Open
remilapeyre wants to merge 7 commits intopython:mainfrom
remilapeyre:convert-key-to-string-when-accessing-configparser
Open

bpo-35954: Clarify string conversion in ConfigParser#11918
remilapeyre wants to merge 7 commits intopython:mainfrom
remilapeyre:convert-key-to-string-when-accessing-configparser

Conversation

@remilapeyre
Copy link
Copy Markdown

@remilapeyre remilapeyre commented Feb 18, 2019 •
edited
Loading

@csabella csabella added the stale Stale PR or inactive for long period of time. label Nov 16, 2019
@csabella
Copy link
Copy Markdown
Contributor

csabella commented Jan 10, 2020

@remilapeyre, it looks like the decision on the bug tracker was to make this a doc change. If you can, please make that requested change or, otherwise, please close the pull request. Thank you!

@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented Jan 20, 2020

Hi @csabella, it should be OK now.

@csabella csabella requested a review from taleinat January 20, 2020 17:51
@csabella csabella removed the stale Stale PR or inactive for long period of time. label Jan 20, 2020
@csabella csabella requested review from taleinat and removed request for taleinat May 28, 2020 23:36
taleinat
taleinat requested changes May 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay reviewing this! I like the direction, but would like some changes before this goes in.

Comment thread Doc/library/configparser.rst Outdated
Comment thread Doc/library/configparser.rst Outdated
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 30, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre remilapeyre changed the title bpo-35954: Convert key to string when accessing ConfigParser bpo-35954: Clarify string conversion in ConfigParser Jun 1, 2020
@remilapeyre
Copy link
Copy Markdown
Author

remilapeyre commented Jun 1, 2020

Thanks @taleinat for the review! I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 1, 2020

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from taleinat June 1, 2020 00:32
iritkatriel
iritkatriel reviewed May 21, 2021
View reviewed changes
Comment thread Doc/library/configparser.rst Outdated
@remilapeyre @iritkatriel
Update Doc/library/configparser.rst
5a6a8f7 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@remilapeyre remilapeyre requested a review from iritkatriel May 2, 2024 17:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 15, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat Awaiting requested review from taleinat

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting change review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@remilapeyre @csabella @bedevere-bot @taleinat @iritkatriel @auvipy @the-knights-who-say-ni @ezio-melotti