bpo-36121: Override field_size_limit per csv.reader object#12071
Open
remilapeyre wants to merge 2 commits intopython:mainfrom
Open
bpo-36121: Override field_size_limit per csv.reader object#12071remilapeyre wants to merge 2 commits intopython:mainfrom
remilapeyre wants to merge 2 commits intopython:mainfrom
Conversation
remilapeyre
force-pushed
the
override-csv.field_size_limit
branch
2 times, most recently
from
b10f1dc to
be2a5ec
Compare
remilapeyre
force-pushed
the
override-csv.field_size_limit
branch
from
be2a5ec to
f2d530f
Compare
Contributor
ZackerySpytz
left a comment
ZackerySpytz
left a comment
There was a problem hiding this comment.
I'm not sure if this feature will be accepted, but I have some comments.
Author
|
Thanks, it took me a while but I made the changes you requested. |
|
I don't know the typical times for a PR like this one to be accepted, but if it helps to find the motivation to accept it, the original bug was submitted because of this conversation in the Scipy repository: scipy/scipy#9854 (comment) |
MaxwellDupre
approved these changes
May 12, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Run of test_csv:
Ran 107 tests in 0.327s
OK
It would be good to add in csv.rst:
Changed in version 3.12
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36121