gh-115783: Deprecate support for invalid ISO formats in datetime.fromisoformat#131522
gh-115783: Deprecate support for invalid ISO formats in datetime.fromisoformat#131522StanFromIreland wants to merge 10 commits intopython:mainfrom
datetime.fromisoformat#131522Conversation
pganssle
left a comment
There was a problem hiding this comment.
Note: Before we go too far with this I would like to start a thread on discourse to try and gauge how disruptive this is likely to be, and whether other folks agree that we should deprecate instead of just fixing the function.
It is the safe and cautious thing to do to issue a warning, but also we aren't technically deprecating anything since we didn't intend for this function to be able to parse things other than the output of isoformat or valid ISO 8601 date/time strings.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
|
This PR is stale because it has been open for 30 days with no activity. |
This deprecates the support for invalid formats in
datetime.fromisoformatto be removed in 3.15.