gh-133510: Added Resources section#133559
Closed
Nneoma00 wants to merge 1 commit intopython:mainfrom
Closed
Conversation
ZeroIntensity
requested changes
May 7, 2025
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
There's already a PR up for gh-133510, and we shouldn't be linking to other Python tutorials.
| For more detailed explanation and additional examples, you can look into the | ||
| following resources, which are written in tutorial format: | ||
| - :pep:`636` | ||
| - `W3Schools <https://www.w3schools.com/python/python_match.asp>`_ |
Member
There was a problem hiding this comment.
I don't think it's a good idea to link to other documentation pages that we don't control. I'm particularly against linking W3Schools, considering their example of creating a tuple looks like this:
x = tuple(("apple", "banana", "cherry"))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #133511 :
points out the lack of detailed examples and use cases for the match statement in Python
I added a resources section, and listed 2 sites(hyperlinks) for beginners seeking examples/tutorials to find, in addition to the previously linked PEP 636 tutorial.
📚 Documentation preview 📚: https://cpython-previews--133559.org.readthedocs.build/