Skip to content

gh-117208: handle EAGAIN in non-blocking connect #134688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duaneg wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −1
Open

gh-117208: handle EAGAIN in non-blocking connect #134688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
187a3e6
gh-117208: handle EAGAIN in non-blocking connect
duaneg May 25, 2025
276adae
Fix reference target
duaneg May 26, 2025
9ff2d07
Try again to correct the reference in the NEWS entry
duaneg May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2025-05-26-01-48-09.gh-issue-117208.mmFGDb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix error handling for non-blocking ``connect`` calls which meant
:meth:`socket.socket.connect` was sometimes raising a :exc:`BlockingIOError`
instead of waiting when a connection could not be immediately completed.
3 changes: 2 additions & 1 deletion Modules/socketmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3671,7 +3671,8 @@ internal_connect(PySocketSockObject *s, struct sockaddr *addr, int addrlen,
wait_connect = (s->sock_timeout != 0 && IS_SELECTABLE(s));
}
else {
wait_connect = (s->sock_timeout > 0 && err == SOCK_INPROGRESS_ERR
wait_connect = (s->sock_timeout > 0
&& (err == EAGAIN || err == SOCK_INPROGRESS_ERR)
&& IS_SELECTABLE(s));
}

Expand Down
Loading