gh-135511 Fixed NameError and AttributeError lack of the message in IDLE

[Locked-chess-official]

#135511

• Issue: NameError has different actions when be raised in IDLE #135511

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[Locked-chess-official]

I use blurb to create a .rst file then click add file and choose it to IDLE, but it was wrong. So how should I do?

[terryjreedy]

To add a test, I think if might be sufficient to add the following tuple to the end of data in test_idle.test_run.ExceptionTest.

            ('raise NameError("123\n456")', NameError, "123\n456\n"),

If you want me to make changes and test, I will, but I need sleep now.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[terryjreedy]

The hint process is rather fragile. Modifying get_message_lines so that sys.excepthook does not print any traceback, which require setting err.traceback to None before the call in addition to not passing a traceback, can alter the hint. In particular, for abc, "Did you mean: 'abs'?" is omitted and only "Did you forget to import 'abc'?" is added. Not only do the message changes break multiple tests, but this particular result is worse for the user. I am accepting the alternative of directly printing multiline user name error messages instead of calling a modified get_message_lines. I will look at adding a new test_xxx function to test the case fixed here.

[Locked-chess-official]

I have made the requested changes; please review again

[bedevere-app]

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

[Locked-chess-official]

@terryjreedy

[Locked-chess-official]

To add the test, I have to add a new default for print_exception(), now is print_exception(in_test=False). When in test, nothing will be print to sys.stderr. It is for test_run.py. In test_run.py, it needs to change the test to exec mode and use another way to test.

[Locked-chess-official]

I make the change clearer now.

[github-actions]

This PR is stale because it has been open for 30 days with no activity.