gh-127264: Update document behavior of Path.resolve()#135531
Open
wei-juncheng wants to merge 1 commit intopython:mainfrom
Open
gh-127264: Update document behavior of Path.resolve()#135531wei-juncheng wants to merge 1 commit intopython:mainfrom
wei-juncheng wants to merge 1 commit intopython:mainfrom
Conversation
…ry and existence checks
Contributor
|
Should we also add this to |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127264
What
Issue #127264 pointed out that users relying on
exists()as a safe pre-check forresolve()may still encounter an unexpectedFileNotFoundErrorwhen the cwd is gone. This note:getcwd()call).exists()can race with filesystem changes.How
Doc/library/pathlib.rstto document thatPath.resolve(strict=False)will callos.getcwd()internally and thus can raiseFileNotFoundErrorif the current working directory has been deleted.📚 Documentation preview 📚: https://cpython-previews--135531.org.readthedocs.build/