Remove unneeded zlib dependency in zipfile tests#135631
Open
danny0838 wants to merge 1 commit intopython:mainfrom
Open
Remove unneeded zlib dependency in zipfile tests#135631danny0838 wants to merge 1 commit intopython:mainfrom
zlib dependency in zipfile tests#135631danny0838 wants to merge 1 commit intopython:mainfrom
Conversation
- Use `zipfile.crc32` rather than `zlib.crc32` since it can work without `zlib`.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
zipfile.crc32rather thanzlib.crc32since it can work withoutzlib.This seems to be an obvious and trivial improvement and I'd just skip raising an issue.