gh-137146: Restrict IPvFuture address parsing to RFC 3986-valid characters#137147
Open
mauricelambert wants to merge 6 commits intopython:mainfrom
Open
gh-137146: Restrict IPvFuture address parsing to RFC 3986-valid characters#137147mauricelambert wants to merge 6 commits intopython:mainfrom
mauricelambert wants to merge 6 commits intopython:mainfrom
Conversation
…acters
IPvFuture hostnames in URLs were being matched using a too-permissive regex
(`.+`), which allowed invalid characters not defined by RFC 3986.
This patch updates the pattern to only accept characters explicitly allowed
by the RFC for IPvFuture addresses.
According to RFC 3986 §3.2.2, the format of IPvFuture is:
"v" 1*HEXDIG "." 1*( unreserved / sub-delims / ":" )
Where:
- unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~"
- sub-delims = "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "="
Before the fix:
>>> import urllib.parse
>>> urllib.parse.urlparse("http://[v45.test|test]/path")
ParseResult(scheme='http', netloc='[v45.test|test]', path='/path', ...)
Invalid characters such as `|` were incorrectly accepted.
After the fix:
>>> import urllib.parse
>>> urllib.parse.urlparse("http://[v45.test|test]/path")
Traceback (most recent call last):
...
ValueError: IPvFuture address is invalid
This improves standards compliance and prevents malformed URLs from being
silently accepted.
StanFromIreland
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes overly permissive validation of IPvFuture hostnames in
urllib.parse(#137146).Previously, the regex used to match IPvFuture (
v...) components allowed all characters (.+), which is incorrect. According to RFC 3986 §3.2.2, an IPvFuture should match the following structure:Where:
unreserved= ALPHA / DIGIT / "-" / "." / "_" / "~"sub-delims= "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "="This patch replaces the permissive regex with one that strictly enforces this allowed character set.
Before the fix:
After the fix:
This improves standards compliance and helps prevent silent acceptance of malformed or unsafe host components.
urllib.parseaccepts invalid characters in IPv6 ZoneIDs and IPvFuture addresses #137146