Skip to content

gh-123471: Make concurrent iteration over itertools.islice thread-safe #144528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eendebakpt wants to merge 8 commits into from
Closed

gh-123471: Make concurrent iteration over itertools.islice thread-safe #144528

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5fb151
Make itertools.islice safe in the FT build
eendebakpt Feb 5, 2026
6492f2f
add test
eendebakpt Feb 5, 2026
443404e
atomic store of lz->next
eendebakpt Feb 5, 2026
e1e61df
use step as sentinel
eendebakpt Feb 5, 2026
c2cbffb
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 5, 2026
572c071
Merge branch 'main' into islice_ft
eendebakpt Feb 5, 2026
b406b7f
Merge branch 'main' into islice_ft
eendebakpt Feb 23, 2026
e71b7b8
Merge branch 'main' into islice_ft
eendebakpt Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@eendebakpt
eendebakpt committed Feb 5, 2026
commit 6492f2feed947fe51937421f0cfdfff9f9aed677
9 changes: 8 additions & 1 deletion Lib/test/test_free_threading/test_itertools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import unittest
from itertools import batched, chain, combinations_with_replacement, cycle, permutations
from itertools import batched, chain, combinations_with_replacement, cycle, islice, permutations
from test.support import threading_helper


Expand Down Expand Up @@ -48,6 +48,13 @@ def test_combinations_with_replacement(self):
it = combinations_with_replacement(tuple(range(2)), 2)
threading_helper.run_concurrently(work_iterator, nthreads=6, args=[it])

@threading_helper.reap_threads
def test_islice(self):
number_of_iterations = 6
for _ in range(number_of_iterations):
it = islice(tuple(range(10)), 1, 8, 2)
threading_helper.run_concurrently(work_iterator, nthreads=10, args=[it])

@threading_helper.reap_threads
def test_permutations(self):
number_of_iterations = 6
Expand Down