bpo-39452: Improve the __main__ module documentation#14487
bpo-39452: Improve the __main__ module documentation#14487geryogam wants to merge 5 commits intopython:mainfrom
Conversation
|
🤖 Mariatta was mentioned, but she's out of open source until end of September 2019. Hopefully someone else can look into this in the meantime. |
|
@maggyero, please open a bug tracker ticket for this. That will provide the chance for more people to see the change and comment on it. Thanks! |
|
Done @csabella. |
terryjreedy
left a comment
There was a problem hiding this comment.
To me, at least the first two changes in the description are wrong. See the issue for discussion.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
|
Remove trailing whitespace with patchcheck, as mentioned in devguide. |
|
@stevendaprano Changes were made in response to your review on the issue. |
Done. |
|
Closing in favor of GH-26883. |
This PR will apply the following changes on the
__main__module documentation:__main__module is also initialized (when using the-cand-marguments);-margument also performs import for instance;ifbody (all the cases when the module is not initialized from an import statement);ifblock comment PEP 8-compliant (capital initialised, period ended);https://bugs.python.org/issue39452