gh-149217: Avoid adding dependencies on immutable, immortal classes in the JIT#149256
gh-149217: Avoid adding dependencies on immutable, immortal classes in the JIT#149256Wulian233 wants to merge 1 commit intopython:mainfrom
Conversation
Wulian233
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Produces better code, and is net -4 lines 🙂
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Actually, there is some code that should be removed.
Will be good once that's done.
| @@ -148,8 +148,7 @@ dummy_func(void) { | |||
| sym_set_type(owner, probable_type); | |||
| sym_set_type_version(owner, type_version); | |||
| if ((probable_type->tp_flags & Py_TPFLAGS_IMMUTABLETYPE) == 0) { | |||
There was a problem hiding this comment.
Remove this test (which is wrong as it doesn't check for mortalitiy)
| @@ -237,8 +236,7 @@ dummy_func(void) { | |||
| else { | |||
| sym_set_const(owner, type); | |||
| if ((((PyTypeObject *)type)->tp_flags & Py_TPFLAGS_IMMUTABLETYPE) == 0) { | |||
There was a problem hiding this comment.
Remove this test (which is wrong as it doesn't check for mortalitiy)
| @@ -2026,8 +2022,7 @@ dummy_func(void) { | |||
| ADD_OP(_SWAP, 3, 0); | |||
| optimize_pop_top(ctx, this_instr, method_and_self[0]); | |||
| if ((type->tp_flags & Py_TPFLAGS_IMMUTABLETYPE) == 0) { | |||
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
4 participants
skip news