[3.14] gh-149117: Set ImportError.name on errors from runpy.run_module/run_path (gh-149159)#149257
Merged
ncoghlan merged 1 commit intopython:3.14from May 2, 2026
Merged
Conversation
…ule`/`run_path` (pythongh-149159) Set ImportError.name on errors from runpy.run_module/run_path `runpy.run_module()` and `runpy.run_path()` now set the `name` attribute of the `ImportError` they raise to the requested module name, matching the behaviour of a regular import statement (previously `name` was always `None`, which broke introspection). The `name=` kwarg is gated on `issubclass(error, ImportError)` because `_get_module_details()` is also used by `_run_module_as_main()` with a private `_Error` sentinel class. `_Error` does not subclass ImportError, and `BaseException.__init__` rejects unknown kwargs at the C level, so passing `name=` unconditionally would break the `python -m foo` codepath. (cherry picked from commit ff35fe4) Co-authored-by: W. H. Wang <mattwang44@gmail.com>
Documentation build overview
413 files changed ·
|
ncoghlan
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set ImportError.name on errors from runpy.run_module/run_path
runpy.run_module()andrunpy.run_path()now set thenameattributeof the
ImportErrorthey raise to the requested module name, matchingthe behaviour of a regular import statement (previously
namewasalways
None, which broke introspection).The
name=kwarg is gated onissubclass(error, ImportError)because_get_module_details()is also used by_run_module_as_main()witha private
_Errorsentinel class._Errordoes not subclassImportError, and
BaseException.__init__rejects unknown kwargs atthe C level, so passing
name=unconditionally would break thepython -m foocodepath.(cherry picked from commit ff35fe4)
Co-authored-by: W. H. Wang mattwang44@gmail.com
runpy.run_modulefor a non-existent module raises anImportErrorwithoutnameset toNone#149117