Skip to content

gh-68525: Implement email.message.Message.__repr__()#18127

Draft
ZackerySpytz wants to merge 2 commits into
python:mainfrom
ZackerySpytz:bpo-24337-email-message-__repr__
Draft

gh-68525: Implement email.message.Message.__repr__()#18127
ZackerySpytz wants to merge 2 commits into
python:mainfrom
ZackerySpytz:bpo-24337-email-message-__repr__

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Jan 22, 2020

Comment thread Lib/email/message.py

def __repr__(self):
return f"{self.__class__.__name__} with {len(self._headers)} " \
f"headers and Content-Type {self._default_type}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the suggestion in the issue. self._default_type is also wrong, since that's just the default, not the actual content-type of the message (which comes from the headers).

What exactly goes in the repr should be discussed further in the issue.

@bedevere-bot
Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Copy Markdown
Contributor

@ZackerySpytz please address the code review. Thank you!

@erlend-aasland erlend-aasland changed the title bpo-24337: Implement email.message.Message.__repr__() gh-68525: Implement email.message.Message.__repr__() Jan 5, 2024
@erlend-aasland erlend-aasland marked this pull request as draft January 5, 2024 15:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants