gh-83854: Map errno==ETIME to TimeoutError#20253
gh-83854: Map errno==ETIME to TimeoutError#20253ZackerySpytz wants to merge 4 commits intopython:mainfrom
errno==ETIME to TimeoutError#20253Conversation
YoSTEALTH
left a comment
YoSTEALTH
left a comment
There was a problem hiding this comment.
Doc/library/exceptions.rst needs to be updated as well
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
Is it possible to add a test for this? I realize it might be difficult, so it's not a show stopper, but it would be good to test newly added code. There are a few ETIMEDOUT tests, so maybe they could be used as a guide?
Updated blurb to reflect that it's an OSError that's being mapped to a TimeoutError.
| +-- PermissionError EACCES, EPERM | ||
| +-- ProcessLookupError ESRCH | ||
| +-- TimeoutError ETIMEDOUT | ||
| +-- TimeoutError ETIME, ETIMEDOUT |
There was a problem hiding this comment.
I guess this test is as good as we're going to get.
There was a problem hiding this comment.
To be honest, I'm having second thoughts w.r.t. this PR (especially after the discussion
on python-dev). I don't know a lot about ETIME. I'm not sure if I should have submitted this PR.
There was a problem hiding this comment.
@ZackerySpytz No need to worry, its only being added to future version of python. With more and more async style coding being adapted ETIME will be handy to have as TimeoutError. It should have been adapted a long time ago but i suppose no one wanted to bother submitting a PR for it.
erlend-aasland
changed the title
errno==ETIME to TimeoutError
|
This PR is stale because it has been open for 30 days with no activity. |
8 participants
https://bugs.python.org/issue39673