Skip to content

gh-85028: Don't set wShowWindow if startupinfo has STARTF_USESHOWWINDOW#20975

Open
ZackerySpytz wants to merge 2 commits into
python:mainfrom
ZackerySpytz:bpo-40851-win-Popen-shell
Open

gh-85028: Don't set wShowWindow if startupinfo has STARTF_USESHOWWINDOW#20975
ZackerySpytz wants to merge 2 commits into
python:mainfrom
ZackerySpytz:bpo-40851-win-Popen-shell

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Jun 19, 2020 •
edited by bedevere-bot
Loading

@ZackerySpytz ZackerySpytz requested a review from gpshead as a code owner June 19, 2020 05:52
@furkanonder
Copy link
Copy Markdown
Contributor

furkanonder commented May 10, 2023

@ZackerySpytz Could you solve the conflicts?

@arhadthedev arhadthedev changed the title bpo-40851: Don't set wShowWindow if startupinfo has STARTF_USESHOWWINDOW gh-85028: Don't set wShowWindow if startupinfo has STARTF_USESHOWWINDOW May 10, 2023
serhiy-storchaka
serhiy-storchaka requested changes Feb 28, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2020-06-19-00-14-52.bpo-40851.0-3EJP.rst
Comment on lines +1 to +2
On Windows, :class:`subprocess.Popen` no longer sets ``wShowWindow`` if the
``startupinfo`` argument has the flag ``STARTF_USESHOWWINDOW``.
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It describes what the code does, but not what it means for the user.

It can be acceptable in the commit message, but not in the NEWS entry. Please describe the change in terms of user visible effects.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Feb 28, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@akdor1154 akdor1154 mannequin mentioned this pull request Jul 8, 2024
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka requested changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @furkanonder @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot