bpo-42112: ZipInfo.from_file removes only needed slashes#22871
bpo-42112: ZipInfo.from_file removes only needed slashes#22871matan1008 wants to merge 4 commits intopython:mainfrom
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day We also demand... A SHRUBBERY! You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
left a comment
There was a problem hiding this comment.
Everything looks ok; all tests pass. But there is zero documentation, not here, not in the original issue. Could you add some description please, possibly a test case? Also, don't see any test for this change, could add please?
MaxwellDupre
left a comment
There was a problem hiding this comment.
Ah yes I see it now:
test_reading_archive_member_starts_with_slash (test.test_zipfile.OtherTests) ... ok
Your changes are in from_file but the test is in Other.Tests
Is there a reason for that?
Ok, but the info for this change in minimalist in the extreme.
|
This PR is stale because it has been open for 30 days with no activity. |
https://bugs.python.org/issue42112