Skip to content

gh-53698: Fix SAX2DOM handling of PIs before the first XML element#23012

Open
ZackerySpytz wants to merge 3 commits intopython:mainfrom
ZackerySpytz:bpo-9453-SAX2DOM-PI-handling
Open

gh-53698: Fix SAX2DOM handling of PIs before the first XML element#23012
ZackerySpytz wants to merge 3 commits intopython:mainfrom
ZackerySpytz:bpo-9453-SAX2DOM-PI-handling

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Oct 28, 2020 •
edited by bedevere-app Bot
Loading

@ZackerySpytz @JonathanGossage
bpo-9453: Fix SAX2DOM handling of PIs before the first XML element
edbb823 
Co-Authored-By: Jonathan Gossage <jgossage@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
MaxwellDupre

This comment was marked as outdated.

Sign in to view

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 30, 2022
@erlend-aasland erlend-aasland changed the title bpo-9453: Fix SAX2DOM handling of PIs before the first XML element gh-53698: Fix SAX2DOM handling of PIs before the first XML element Jan 5, 2024
@marksmith marksmith mannequin mentioned this pull request Jan 5, 2024
Open
serhiy-storchaka
serhiy-storchaka requested changes Feb 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not they be added to the document node instead of dropped away?

Also, there is the same issue with comments.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Feb 27, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka requested changes

@taleinat taleinat Awaiting requested review from taleinat

+1 more reviewer

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZackerySpytz @serhiy-storchaka @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @bedevere-bot @erlend-aasland