Skip to content

gh-86254: Use "SimpleNamespace(...)" in the repr for SimpleNamespace #23502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZackerySpytz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-86254: Use "SimpleNamespace(...)" in the repr for SimpleNamespace #23502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a1d2e7
bpo-42088: Use "SimpleNamespace(...)" in the repr for SimpleNamespace
ZackerySpytz Nov 24, 2020
fc24834
Merge branch 'main' into bpo-42088-types-SimpleNamespace-repr
erlend-aasland Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_pprint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,12 +450,12 @@ def test_mapping_proxy(self):
def test_empty_simple_namespace(self):
ns = types.SimpleNamespace()
formatted = pprint.pformat(ns)
self.assertEqual(formatted, "namespace()")
self.assertEqual(formatted, "SimpleNamespace()")

def test_small_simple_namespace(self):
ns = types.SimpleNamespace(a=1, b=2)
formatted = pprint.pformat(ns)
self.assertEqual(formatted, "namespace(a=1, b=2)")
self.assertEqual(formatted, "SimpleNamespace(a=1, b=2)")

def test_simple_namespace(self):
ns = types.SimpleNamespace(
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,7 +1815,7 @@ def test_repr(self):
ns2 = types.SimpleNamespace()
ns2.x = "spam"
ns2._y = 5
name = "namespace"
name = "SimpleNamespace"

self.assertEqual(repr(ns1), "{name}(x=1, y=2, w=3)".format(name=name))
self.assertEqual(repr(ns2), "{name}(x='spam', _y=5)".format(name=name))
Expand Down Expand Up @@ -1865,7 +1865,7 @@ def test_recursive_repr(self):
ns1.spam = ns1
ns2.spam = ns3
ns3.spam = ns2
name = "namespace"
name = "SimpleNamespace"
repr1 = "{name}(c='cookie', spam={name}(...))".format(name=name)
repr2 = "{name}(spam={name}(x=1, spam={name}(...)))".format(name=name)

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2020-11-24-13-55-52.bpo-42088.tjTf-0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The repr of :class:`types.SimpleNamespace` is now ``SimpleNamespace(...)``
instead of ``namespace(...)``.
2 changes: 1 addition & 1 deletion Objects/namespaceobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ namespace_repr(PyObject *ns)
PyObject *separator, *pairsrepr, *repr = NULL;
const char * name;

name = Py_IS_TYPE(ns, &_PyNamespace_Type) ? "namespace"
name = Py_IS_TYPE(ns, &_PyNamespace_Type) ? "SimpleNamespace"
: Py_TYPE(ns)->tp_name;

i = Py_ReprEnter(ns);
Expand Down