Skip to content

gh-69057: Add startline and endline attributes to the tokens returned by shlex#2799

Open
gareth-rees wants to merge 2 commits intopython:mainfrom
gareth-rees:fix-issue-24869
Open

gh-69057: Add startline and endline attributes to the tokens returned by shlex#2799
gareth-rees wants to merge 2 commits intopython:mainfrom
gareth-rees:fix-issue-24869

Conversation

@gareth-rees
Copy link
Copy Markdown
Contributor

@gareth-rees gareth-rees commented Jul 21, 2017 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Dec 8, 2018
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 29, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 29, 2022
@arhadthedev arhadthedev changed the title bpo-24869: Add startline and endline attributes to the tokens returned by shlex gh-69057: Add startline and endline attributes to the tokens returned by shlex Feb 14, 2023
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 15, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 18, 2023
@arhadthedev
Copy link
Copy Markdown
Member

arhadthedev commented Apr 13, 2023

Changing token type from str to Token breaks backward compatibility with existing Python libraries that use shlex and may rely on tokens being comparable with strings. Is there a way to fix it in this PR?

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Apr 14, 2023
@gareth-rees
Copy link
Copy Markdown
Contributor Author

gareth-rees commented Apr 20, 2023

Changing token type from str to Token breaks backward compatibility with existing Python libraries that use shlex and may rely on tokens being comparable with strings. Is there a way to fix it in this PR?

Token inherits from str so everything will continue to work except for code that does silly stuff like checking type(token) is str instead of isinstance(token, str).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gareth-rees @arhadthedev @brettcannon @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot