Skip to content

bpo-31368: Expose preadv (preadv2) and pwritev (pwritev2) in the os module #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 14 commits into from
Jan 27, 2018
Merged

bpo-31368: Expose preadv (preadv2) and pwritev (pwritev2) in the os module #5239

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ea21128
Expose preadv2 in os module
pablogsal Jan 19, 2018
4570976
Add News entry
pablogsal Jan 19, 2018
21a3004
Add correct guards for the presence of preadv2
pablogsal Jan 19, 2018
8a2a2a3
Implement check for individual constants
pablogsal Jan 19, 2018
c0c53dc
Implemented preadv and join implementation to preadv2
pablogsal Jan 19, 2018
4ddbca9
Clean iov on error
pablogsal Jan 20, 2018
cac62ac
Add documentation in the os module
pablogsal Jan 22, 2018
c7b7285
Add information about the rest of the parameters
pablogsal Jan 22, 2018
58910d0
Expose pwritev and pwritev2 in os module
pablogsal Jan 23, 2018
f7cdf22
Fix style issues and Docs
pablogsal Jan 23, 2018
47f65b5
Correct style, update docs, fix misused API
pablogsal Jan 23, 2018
87c6970
Improve tests, clean names and correct style
pablogsal Jan 26, 2018
cb74d38
Correct documentation
pablogsal Jan 26, 2018
5563b8d
Correct typos, docstring and improve Docs
pablogsal Jan 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement check for individual constants
  • Loading branch information
@pablogsal
pablogsal committed Jan 20, 2018
commit 8a2a2a31db2af445f0cfdb987aad42a03f3d1ed1
8 changes: 7 additions & 1 deletion Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13012,10 +13012,16 @@ all_ins(PyObject *m)
if (PyModule_AddIntMacro(m, F_TEST)) return -1;
#endif

#ifdef HAVE_PREADV2
#ifdef RWF_DSYNC
if (PyModule_AddIntConstant(m, "RWF_DSYNC", RWF_DSYNC)) return -1;
#endif
#ifdef RWF_HIPRI
if (PyModule_AddIntConstant(m, "RWF_HIPRI", RWF_HIPRI)) return -1;
#endif
#ifdef RWF_SYNC
if (PyModule_AddIntConstant(m, "RWF_SYNC", RWF_SYNC)) return -1;
#endif
#ifdef RWF_NOWAIT
if (PyModule_AddIntConstant(m, "RWF_NOWAIT", RWF_NOWAIT)) return -1;
#endif
Copy link
Copy Markdown
Contributor

@njsmith njsmith Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constants were added at different times, so they should be checked for individually, like:

#ifdef RWF_DSYNC
    if (PyModule_AddIntConstant(m, "RWF_DSYNC", RWF_DSYNC)) return -1;
#endif
#ifdef RWF_HIPRI
    if (PyModule_AddIntConstant(m, "RWF_HIPRI", RWF_HIPRI)) return -1;
#endif
...

Copy link
Copy Markdown
Contributor

@YoSTEALTH YoSTEALTH Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also EOPNOTSUPP flag might be important to add?

Copy link
Copy Markdown
Contributor

@njsmith njsmith Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already available as errno.EOPNOTSUPP.


Expand Down