bpo-1025395: Fix email.utils.parseaddr to handle multiple hops#6917
Closed
ioanatia wants to merge 1 commit intopython:masterfrom
Closed
bpo-1025395: Fix email.utils.parseaddr to handle multiple hops#6917ioanatia wants to merge 1 commit intopython:masterfrom
ioanatia wants to merge 1 commit intopython:masterfrom
Conversation
Member
|
@bitdancer any chance of a review of this? |
Member
|
@warsaw or @bitdancer Will one of you be able to review this please? Thanks. |
maxking
reviewed
Jun 14, 2019
| @@ -0,0 +1 @@ | |||
| Fix email.utils.parseaddr to handle multiple hops | |||
Contributor
There was a problem hiding this comment.
I'd suggest a slight change to wrap email.utils.parseaddr in double backticks "``" so that it is rendered correctly with code in rst format.
Also, can you can add a full stop at the end of the sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a very old issue with
email.utils.parseaddr.Right now
email.utils.parseaddrwill fail to parse the input correctly when the address contains a route with multiple hops. However it does not have an issue with single hop routes.RFC5322 states that including route hops is obsolete and that the route part should be ignored (Section 4.4). It also states that this syntax is valid and it must be accepted and parsed (Section 4).
https://bugs.python.org/issue1025395
This is a duplicate of #142 , the Travis build failing because of changes unrelated to the PR. I have rebased my old branch on latest master, but that still does not seem to help. 🤔 🐱 . @Mariatta