Skip to content

Adds drop handler and MSI registration. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 2 commits into from
Nov 13, 2025
Merged

Adds drop handler and MSI registration. #218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b049c1
Adds drop handler and MSI registration.
zooba Nov 12, 2025
13168c0
Review comments
zooba Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Review comments
  • Loading branch information
@zooba
zooba committed Nov 13, 2025
commit 13168c050db6cb83f330bca3ae5e38ff60f270e3
14 changes: 11 additions & 3 deletions src/pyshellext/shellext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,13 +548,13 @@ class DECLSPEC_UUID(CLSID_DRAGDROPSUPPORT) DragDropSupport : public RuntimeClass
cfDropDescription = RegisterClipboardFormat(CFSTR_DROPDESCRIPTION);
}
if (!cfDropDescription) {
OutputDebugString(L"PyShellExt::DllMain - failed to get CFSTR_DROPDESCRIPTION format");
OutputDebugString(L"PyShellExt::DragDropSupport - failed to get CFSTR_DROPDESCRIPTION format");
}
if (!cfDragWindow) {
cfDragWindow = RegisterClipboardFormat(L"DragWindow");
}
if (!cfDragWindow) {
OutputDebugString(L"PyShellExt::DllMain - failed to get DragWindow format");
OutputDebugString(L"PyShellExt::DragDropSupport - failed to get DragWindow format");
}
}

Expand Down Expand Up @@ -771,10 +771,13 @@ class DECLSPEC_UUID(CLSID_DRAGDROPSUPPORT) DragDropSupport : public RuntimeClass
// IDropTarget implementation

STDMETHODIMP DragEnter(IDataObject *pDataObj, DWORD grfKeyState, POINTL pt, DWORD *pdwEffect) {
HWND hwnd;
HWND hwnd = NULL;

OutputDebugString(L"PyShellExt::DragDropSupport::DragEnter");

Comment thread
zooba marked this conversation as resolved.
if (data_obj) {
data_obj->Release();
}
pDataObj->AddRef();
data_obj = pDataObj;

Expand All @@ -794,10 +797,15 @@ class DECLSPEC_UUID(CLSID_DRAGDROPSUPPORT) DragDropSupport : public RuntimeClass
}

STDMETHODIMP DragLeave() {
Comment thread
zooba marked this conversation as resolved.
if (data_obj) {
data_obj->Release();
data_obj = NULL;
}
return S_OK;
}

STDMETHODIMP DragOver(DWORD grfKeyState, POINTL pt, DWORD *pdwEffect) {
Comment thread
zooba marked this conversation as resolved.
*pdwEffect = DROPEFFECT_MOVE;
return S_OK;
}

Expand Down