internal: cache package#1547
Merged
github-actions[bot] merged 2 commits intoquay:mainfrom Sep 25, 2025
Merged
Conversation
hdonnay
force-pushed
the
hack/cache-package
branch
from
9dc6d32 to
52b66a0
Compare
hdonnay
force-pushed
the
hack/cache-package
branch
from
52b66a0 to
6391abe
Compare
hdonnay
force-pushed
the
hack/cache-package
branch
4 times, most recently
from
95d2062 to
dab8c14
Compare
Member
Author
|
Undrafting this because I'd like to use it in the fetcher. |
hdonnay
force-pushed
the
hack/cache-package
branch
from
dab8c14 to
10194f7
Compare
hdonnay
force-pushed
the
hack/cache-package
branch
from
10194f7 to
bdffb0b
Compare
hdonnay
force-pushed
the
hack/cache-package
branch
3 times, most recently
from
0d7fd6d to
f458ca7
Compare
crozzy
reviewed
Sep 16, 2025
Contributor
crozzy
left a comment
crozzy
left a comment
There was a problem hiding this comment.
LGTM, just a couple of comments
BradLugo
reviewed
Sep 22, 2025
hdonnay
force-pushed
the
hack/cache-package
branch
2 times, most recently
from
a50df82 to
869a57c
Compare
BradLugo
approved these changes
Sep 24, 2025
| } | ||
| a, b = nil, nil | ||
|
|
||
| for range 2 { // Need two cycles: |
Member
Author
There was a problem hiding this comment.
Not entirely; I assume it has to do with marking the pointers dead, then running any cleanups
Contributor
There was a problem hiding this comment.
I double checked this out of curiosity, and it looks like a single runtime.GC() call works on go version go1.25.0 darwin/arm64
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
hack/cache-package
branch
from
869a57c to
a147cd0
Compare
Member
Author
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a generic'd version of the
rpm.PathSetcache.Once merged, that implementation and the refcounting scheme in the fetcher can be replaced with
cache.Live.The package is named
cachebecause we may want different cache strategies in the future, so we can just add more types here (e.g.S3Fifo,LRU).