updaterset: improve cohesion #328
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the logic which invokes Configurable updaterset lives in registry package. IMO, this doesn't really have any association with registry, it is more close to updaterset. Signed-off-by: Arunprasad Rajkumar [email protected]
arajkumar
force-pushed
the
better-updater-cohesion
branch
from
07eb206 to
6d98d88
Compare
Contributor
|
@hdonnay opinion about this? I personally don't disagree here. |
Contributor
|
@arajkumar we agreed on this in today's comm dev meeting. Can you rebase and we will merge? |
Contributor
Author
|
Let me fix matchers/registry.Configure as well. |
Contributor
|
@arajkumar ping on this - we will accept it once its removed from draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic which invokes Configurable updaterset lives in registry package. IMO, this doesn't really have any association with registry, it is more close to updaterset.
Signed-off-by: Arunprasad Rajkumar [email protected]