Started refactoring and added app restart assets.#54
Merged
vishnuchalla merged 8 commits intoquay:masterfrom May 8, 2023
vishnuchalla:dev
Merged
Started refactoring and added app restart assets.#54vishnuchalla merged 8 commits intoquay:masterfrom vishnuchalla:dev
vishnuchalla merged 8 commits intoquay:masterfrom
vishnuchalla:dev
Conversation
syed
reviewed
May 2, 2023
| Attacker().run_vegeta('create_users', reqs, target_name=target_name) | ||
|
|
||
| @staticmethod | ||
| def update_passwords(quay_url, usernames, password): |
Collaborator
There was a problem hiding this comment.
something to note here: This function will work only on a standalone quay deployment and not on quay.io because superuser is disabled in quay.io
Collaborator
Author
There was a problem hiding this comment.
Acknowledged. I am keeping it same for now. Will replace them as below once we get to quay.io in our testing.
POST /api/v1/superuser/users->POST /api/v1/user/for creating users, which is working.- But
PUT /api/v1/superuser/users->PUT /api/v1/user/is not working (Getting 500 error response), may be due to users not having admin roles while being created using/api/v1/userendpoint. Ref: code.
So is there a way to do a PUT operation on /api/v1/user endpoint or is there an endpoint exposed for update user role to admin (Couldn't find one from the list of exposed endpoints)? Because we are using this PUT operation to update user passwords. Please let me know your thoughts on this. Thanks!
syed
approved these changes
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
quay-appafter every run.Testing
Tested on AWS self managed cluster using
quay-operator