Adding list tags and get catalog API endpoints#56
Merged
vishnuchalla merged 18 commits intoquay:masterfrom May 22, 2023
vishnuchalla:dev
Merged
Adding list tags and get catalog API endpoints#56vishnuchalla merged 18 commits intoquay:masterfrom vishnuchalla:dev
vishnuchalla merged 18 commits intoquay:masterfrom
vishnuchalla:dev
Conversation
dmage
reviewed
May 16, 2023
endpoints/tags.py
Outdated
| :param repo: repository of a specified user | ||
| :return: returns the token | ||
| """ | ||
| cmd = ["curl", "-k", "-L", "--user", f"{user}:password", f"https://{quay_host}/v2/auth?service={quay_host}&scope=repository:{user}/{repo}:pull,push"] |
There was a problem hiding this comment.
Why do you use curl instead of doing it in Python via urllib or requests?
Collaborator
Author
There was a problem hiding this comment.
Thanks for bringing this up. Made changes to use python requests library.
dmage
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added list tags and get catalog API endpoints.
Testing
Tested on an AWS cluster. Full logs here: http://pastebin.test.redhat.com/1099853