Closed
Conversation
Frenkiee
reviewed
Feb 4, 2022
| hash TEXT NOT NULL, | ||
| args JSON NOT NULL, | ||
| docs TEXT NOT NULL, | ||
| contract_address_evm_call VARCHAR(48), |
Collaborator
There was a problem hiding this comment.
In my opinion, this does not belong here...
Let's do it like we discussed to have one separate table for EVM events and have foreign keys on contract and event
Frenkiee
reviewed
Feb 4, 2022
crawler/src/queries/extrinsic.ts
Outdated
| }: InsertExtrinsicBody): string => { | ||
| let contractAddress = undefined; | ||
| if(section === 'evm' && method === 'call'){ | ||
| try { |
Collaborator
There was a problem hiding this comment.
Aren't two try catches a bit of an overkill?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.