Fix Windows default browser open issue#2
Conversation
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
Thanks for working on this! I requested a couple of small changes. Please squash them into the existing commit and force push. Then we can merge it!
| public void open(final URL url) throws IOException { | ||
| final String cmd; | ||
| final String args; | ||
| // FIXME: the cmd and args separate is necessary for Windows OS |
There was a problem hiding this comment.
Please change FIXME to NB.
The term FIXME means "the code here is not correct, and should be fixed as soon as possible." The term "NB" means "nota bene" = "note well" and indicates an important comment explaining that the code is the way it is for a very important reason, even if it might appear incorrect at first glance.
For details, see http://imagej.net/Coding_style#Javadoc_and_comments
| @Override | ||
| public void open(final URL url) throws IOException { | ||
| final String cmd; | ||
| final String args; |
There was a problem hiding this comment.
I suggest calling this arg instead of args—if there were more than one argument, it would be a String[] instead, right?
panovr
force-pushed
the
fix-win10-browser-open-issue
branch
from
a3a71c4 to
fe3b580
Compare
|
@ctrueden Done. |
|
Thank you! 👍 |
2 participants
See issue 34 discussion.