Use static versioning over setuptools_scm#49
Merged
Conversation
gselzer
force-pushed
the
48-remove-automagic-versioning
branch
from
d5882dd to
c535dfc
Compare
* Rename _scyjava_version to _expected_version, for clarity. * Use imperative tense for docstrings, as per Python convention. * Terminate each docstring sentence with a period.
In this way, it can be used easily by a downstream component to extract its version into its own __version__ dunder as well. And change get_version to raise an exception if extraction fails.
Member
After discussion with @gselzer, I aggressively do not care about this. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining questions:
flake8, the declaration of__version__after the imports technically violates PEP8. Do we care about this?