Skip to content

Add Zulu JDK 7.0.171 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marc0der merged 1 commit into from
Apr 18, 2018
Merged

Add Zulu JDK 7.0.171 #10

marc0der merged 1 commit into from
Apr 18, 2018

Conversation

@vpavic
Copy link
Contributor

@vpavic vpavic commented Apr 16, 2018

No description provided.

marc0der
marc0der reviewed Apr 17, 2018
View reviewed changes
src/main/scala/io/sdkman/changelogs/JavaMigrations.scala Outdated
Version("java", "10.0.0-openjdk", "https://download.java.net/java/GA/jdk10/10/binaries/openjdk-10_osx-x64_bin.tar.gz", MacOSX))
}

@ChangeSet(order = "007", id = "007-add_zulu_7_0_171", author = "vpavic")
Copy link
Member

@marc0der marc0der Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this PR can we also clean up the residual 7.0.141-zulu versions please?

@vpavic vpavic force-pushed the add_zulu_7_0_171 branch from f7d45e8 to 2f6c449 Compare April 17, 2018 22:26
@vpavic
Copy link
Contributor Author

vpavic commented Apr 17, 2018

As part of this PR can we also clean up the residual 7.0.141-zulu versions please?

Done.

@marc0der
Copy link
Member

marc0der commented Apr 18, 2018

This seems to be conflicting with your previous PR now, sorry! Could you rebase against master and make any appropriate changes please?

In future, it might be easier to do all such changes in a single PR. wdyt?

@vpavic vpavic force-pushed the add_zulu_7_0_171 branch from 2f6c449 to 98f9b43 Compare April 18, 2018 12:34
@vpavic
Copy link
Contributor Author

vpavic commented Apr 18, 2018

This seems to be conflicting with your previous PR now, sorry! Could you rebase against master and make any appropriate changes please?

NP, I've just updated the PR.

In future, it might be easier to do all such changes in a single PR. wdyt?

Sounds good to me. I didn't know what was your policy on this so I went with separate PRs by default.

@marc0der marc0der merged commit de0f3a7 into sdkman:master Apr 18, 2018
@marc0der
Copy link
Member

marc0der commented Apr 18, 2018

Thank you, that's perfect now. Thanks again for contributing!

@vpavic vpavic deleted the add_zulu_7_0_171 branch April 18, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc0der marc0der marc0der left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vpavic @marc0der