Updated maven version from 3.5.3 to 3.5.4 #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0der
requested changes
Jul 20, 2018
Member
There was a problem hiding this comment.
Two things here, this file is deprecated (see the annotation at the top of the file). You need to be updating MavenMigrations.scala. If that doesn't exist, you should create it.
Secondly, a migration can only run if it hasn't been run before so you can't update an existing one but need to add an entirely new entry in that file.
The README.md clearly explains the entire workflow.
added 2 commits
July 20, 2018 12:55
marc0der
approved these changes
Jul 20, 2018
Member
|
Great work! Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.