Skip to content

Conversation

@mdeinum
Copy link
Contributor

@mdeinum mdeinum commented Aug 10, 2018

With this commit the EA candidates for Java 11 and 12 are added.
Java 11 both has an Oracle and OpenJDK version, the Java 12 version
only has an OpenJDK version.

The versioning is like 11.ea25-openjdk as using 11.ea+25-openjdk would
result in a version longer then 15 characters. When the EA candidates can
be removed we can revert back to 11.0.0-openjdk again.

@marc0der
Copy link
Member

I'd like to propose two changes.

Firstly, I would prefer if we drop the Oracle JDK and just go with OpenJDK for EA releases.

Secondly I want to propose that we make the numbering scheme 11.ea.25-openjdk so that we don't break the sorting algorithm.

@marc0der
Copy link
Member

Sorry, and another thing is that all the binaries need to be tarballs if possible. Have they changed their openjdk binary format since JDK 10?

@marc0der
Copy link
Member

Just saw your comment about the version truncation. Maybe we should try 11.e.25-openjdk as the delimiters are very important. wdyt?

@mdeinum
Copy link
Contributor Author

mdeinum commented Aug 13, 2018

  • Dropped Oracle JDK ✅
  • Changed versioning scheme. ✅

Regarding the binaries, I followed the download links for the respective versions. Only linux and Mac have tarballs, windows has a zip. This looks consistent to java 9 and 10. (The Oracle JDK was different indeed but that is removed now).

@marc0der
Copy link
Member

I just checked, and it looks like the format of the openjdk has indeed changed from JDK 9/10 to 11/12.

That said, I've released a change in the backend that will allow for this format to work.

@marc0der marc0der merged commit 077a7f9 into sdkman:master Aug 13, 2018
@marc0der
Copy link
Member

BTW, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants