Skip to content

openjdk 15ea31 and 16ea5 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marc0der merged 4 commits into from
Jul 15, 2020
Merged

openjdk 15ea31 and 16ea5 #284

marc0der merged 4 commits into from
Jul 15, 2020

Conversation

@eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Jul 9, 2020

  • Add OpenJDK 15ea31
  • Add OpenJDK 16ea5

@eddumelendez eddumelendez force-pushed the openjdk_15ea31_and_16ea5 branch from 4565880 to e6747a6 Compare July 14, 2020 20:18
@eddumelendez
Copy link
Member Author

eddumelendez commented Jul 14, 2020

@marc0der broke the build at #287 😢 I have updated this PR with the fix

@marc0der
Copy link
Member

marc0der commented Jul 14, 2020

I fixed it (and also made some optimisations). Please let me know how you like the change.
Shall we do subsequent migrations in this style going forward? wdyt?

@eddumelendez
Copy link
Member Author

eddumelendez commented Jul 14, 2020

thanks for fixing it! and the change looks much better! I will update my PR

@marc0der
Copy link
Member

marc0der commented Jul 14, 2020

I've also just trimmed away all but the last 3 migrations. Sorry, giving you more work!

@eddumelendez eddumelendez force-pushed the openjdk_15ea31_and_16ea5 branch from e6747a6 to a66de47 Compare July 14, 2020 21:11
@eddumelendez
Copy link
Member Author

eddumelendez commented Jul 14, 2020

@marc0der PR updated. hopefully no syntax error this time 🙈

@marc0der
Copy link
Member

marc0der commented Jul 15, 2020

Looks great! I suggest we just keep reusing these three constructs from now on (in other words, increment the ChangeSets and reuse these three blocks of code without accumulation). In the end, version control will give us all the history we require should we need it. How does it sound?

@marc0der marc0der merged commit 2733831 into sdkman:master Jul 15, 2020
@marc0der marc0der mentioned this pull request Jul 15, 2020
Closed
@strizhik strizhik mentioned this pull request Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eddumelendez @marc0der